Merged
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 11h 13m 32s ⏱️ + 1m 14s For more details on these failures and errors, see this check. Results for commit 729e13a. ± Comparison against base commit bf499a2. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom serialization for
pyarrow.fs.FileInfowas recently added to help with Parquet in Dask DataFrame (xref #9025) but this import isn't quite rightI think this went unnoticed because in the Dask DataFrame case we trigger this correct import first
https://github.com/dask/dask/blob/c8ef947bd38e2b739ad3eccdbcce42e08d8c3f4a/dask/dataframe/dask_expr/io/parquet.py#L21
first which allows the import here to work.
However in the non-Dask DataFrame parquet case, that correct import doesn't happen and folks hit the
AttributeError